gen_stub: stop cloning FramelessFunctionInfo objects

DanielEScherzer · kocsismate · commit 367c5b522a43 · 2025-02-14T08:43:00.000+01:00
They are immutable
diff --git a/build/gen_stub.php b/build/gen_stub.php
@@ -2085,9 +2085,6 @@ public function __clone()
             $this->args[$key] = clone $argInfo;
         }
         $this->return = clone $this->return;
-        foreach ($this->framelessFunctionInfos as $key => $framelessFunctionInfo) {
-            $this->framelessFunctionInfos[$key] = clone $framelessFunctionInfo;
-        }
     }
 }
 
@@ -4227,6 +4224,8 @@ function parseDocComment(DocComment $comment): array {
     return $tags;
 }
 
+// Instances of FramelessFunctionInfo are immutable and do not need to be cloned
+// when held by an object that is cloned
 class FramelessFunctionInfo {
     public /* readonly */ int $arity;
 

Original file line number	Diff line number	Diff line change
`@@ -2085,9 +2085,6 @@ public function __clone()`
`2085`	`2085`	`$this->args[$key] = clone $argInfo;`
`2086`	`2086`	`}`
`2087`	`2087`	`$this->return = clone $this->return;`
`2088`		`- foreach ($this->framelessFunctionInfos as $key => $framelessFunctionInfo) {`
`2089`		`- $this->framelessFunctionInfos[$key] = clone $framelessFunctionInfo;`
`2090`		`- }`
`2091`	`2088`	`}`
`2092`	`2089`	`}`
`2093`	`2090`
`@@ -4227,6 +4224,8 @@ function parseDocComment(DocComment $comment): array {`
`4227`	`4224`	`return $tags;`
`4228`	`4225`	`}`
`4229`	`4226`
	`4227`	`+// Instances of FramelessFunctionInfo are immutable and do not need to be cloned`
	`4228`	`+// when held by an object that is cloned`
`4230`	`4229`	`class FramelessFunctionInfo {`
`4231`	`4230`	`public /* readonly */ int $arity;`
`4232`	`4231`