Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a31fa55b44
Choose a base ref
...
head repository: php/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5de79f9f07
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Sep 22, 2012

  1. Revert error/exception handler changes 

    This reverts the following two commits:

 * 6ba2e66
 * d8f8e98

Laruence already did some partial changes to set_error_handler and
set_exception_handler. I'm reverting those modifications to apply the full
set of changes. (The modifications changed the code structure in a way that
would lead to more duplication with the new behavior.)
    @nikic
    nikic committed Sep 22, 2012
    Configuration menu
    Copy the full SHA
    4954aba View commit details
    Browse the repository at this point in the history

  2. Allow resetting the error handler 

    This allows the error handler to be reset using set_error_handler(null).
As the code suggests this behavior was already previously intended, but
the callback check was done too strictly.
    @nikic
    nikic committed Sep 22, 2012
    Configuration menu
    Copy the full SHA
    c815dd7 View commit details
    Browse the repository at this point in the history

  3. Return previous error handler when resetting the error handler 

    set_error_handler(null) and set_exception_handler(null) now return the
previous error/exception handler instead of just returning bool(true).
This is consistent with the behavior of these functions with non-null
values.
    @nikic
    nikic committed Sep 22, 2012
    Configuration menu
    Copy the full SHA
    f28c128 View commit details
    Browse the repository at this point in the history

  4. Simplify set_error_handler/set_exception_handler code

    @nikic
    nikic committed Sep 22, 2012
    Configuration menu
    Copy the full SHA
    5c7dd78 View commit details
    Browse the repository at this point in the history

  5. Add NEWS/UPGRADING for previous change

    @nikic
    nikic committed Sep 22, 2012
    Configuration menu
    Copy the full SHA
    5de79f9 View commit details
    Browse the repository at this point in the history
Loading