Skip to content

Ignore generated arginfo for the ABI break label #18708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DanielEScherzer opened this issue May 29, 2025 · 4 comments
Open

Ignore generated arginfo for the ABI break label #18708

DanielEScherzer opened this issue May 29, 2025 · 4 comments
Labels
ABI break Category: Build System Feature Status: Needs Triage

Comments

@DanielEScherzer
Copy link
Member

Description

Any objections? From the initial #15682

ABI breaks are not supposed to happen after feature freeze, i.e. when
the PHP API numbers have been bumped. To make it easier to notice
inadvertent ABI breaks, we automatically add an "ABI break" label to
all PRs which modify public (aka. installed) header files.

And I would consider arginfo to qualify as non-public header files
@DanielEScherzer
Copy link
Member Author

CC @cmb69 @iluuu1994 @kocsismate

@iluuu1994
Copy link
Member

Sounds good to me

@cmb69
Copy link
Member

cmb69 commented Jun 2, 2025

I'm fine with this as a stop-gap measure, but we should really stop installing headers which are not supposed to be public (see #16070).

@kocsismate
Copy link
Member

Yes, I also think this make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ABI break Category: Build System Feature Status: Needs Triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iluuu1994 @cmb69 @kocsismate @DanielEScherzer