Remove "register_globals" support codes from php/php_binary serializer #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs. As a result, users may use PS_UNDEF_MAKER(=!) char for session variable name.
|
I removed register_globals back then and it seems like an oversight on my part, so go ahead and commit this :) |
|
@KalleZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes "register_globals" support codes from php/php_binary serializer.
As a result, users may use PS_UNDEF_MAKER(=!) char for session variable name.
This patch is a code cleanup. However, there could be compatibility issue when user mixing old PHP (less than PHP 5.4.0) that supports "register_globals" (i.e. Variables that are registered by session_register()) When session_register()ed variables are undefined, it results in error. Since session_register() is removed in PHP 5.4.0, PHP 5.4.0 or later has no issues.
If there is no comment, I'll merge this in a few days.