Skip to content

ext/mysqli: Drop table at beginning for mysqli_fetch_all_data_types_variation.phpt #18455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NattyNarwhal
Copy link
Member

If the table exists already (i.e. cleanup fails to run on a persistent database instance), then the test will fail to run.

Currently being seen on ppc64 CI:
https://github.com/php/php-src/actions/runs/14721423150/job/41315888822

(Ideally, this test would be run with a fresh DB instance, but I need to figure out the containerization story.)

…ariation.phpt

If the table exists already (i.e. cleanup fails to run on a persistent
database instance), then the test will fail to run.

Currently being seen on ppc64 CI:
https://github.com/php/php-src/actions/runs/14721423150/job/41315888822
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add it but I would rather understand why the table isn't properly removed in a clean up section and address the root cause. This just seems like patching a symptom without addressing the cause.

@NattyNarwhal NattyNarwhal marked this pull request as draft April 29, 2025 22:36
@NattyNarwhal
Copy link
Member Author

I agree; the long term fix is "don't reuse the same MySQL instance to avoid spooky stuff". I've resolved the issue on the system as-is. Just putting this here in case in turns into something recurring and we need to patch it over temporarily.

@iluuu1994
Copy link
Member

Right, it highly doubt this is the only test where this can occur for your runner. So it might be better to just manually drop the table on the server until we can find a proper fix, which is likely server-side anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants