From 51e90175b7fe29b380be554dc55886916d0e7d8f Mon Sep 17 00:00:00 2001 From: Jakub Zelenka Date: Mon, 24 Oct 2022 10:52:50 +0100 Subject: [PATCH] Fix GH-8517: FPM child can be possibly freed before stdio event We should delete event before freeing child so it cannot be triggered after the child is freed. --- sapi/fpm/fpm/fpm_children.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sapi/fpm/fpm/fpm_children.c b/sapi/fpm/fpm/fpm_children.c index fdaeb89d2bf3d..f30fcd62c1ba7 100644 --- a/sapi/fpm/fpm/fpm_children.c +++ b/sapi/fpm/fpm/fpm_children.c @@ -72,6 +72,7 @@ static void fpm_child_close(struct fpm_child_s *child, int in_event_loop) /* {{{ if (child->fd_stdout != -1) { close(child->fd_stdout); } + fpm_event_del(&child->ev_stdout); } if (child->fd_stderr != -1) { @@ -81,6 +82,7 @@ static void fpm_child_close(struct fpm_child_s *child, int in_event_loop) /* {{{ if (child->fd_stderr != -1) { close(child->fd_stderr); } + fpm_event_del(&child->ev_stderr); } fpm_child_free(child);