Skip to content

Commit 2e23d8f

Browse files
committed
Get rid of useless initialization by null.
All class members initialized to null by default. No functional change.
1 parent 4ac4c4a commit 2e23d8f

File tree

6 files changed

+17
-20
lines changed

6 files changed

+17
-20
lines changed

src/ru/mystamps/db/SuspiciousActivities.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import javax.sql.DataSource;
1111

1212
public class SuspiciousActivities {
13-
private DataSource ds = null;
13+
private DataSource ds;
1414

1515
private static final String logEventQuery =
1616
"INSERT INTO `suspicious_activities` " +
@@ -24,8 +24,7 @@ public class SuspiciousActivities {
2424
public SuspiciousActivities()
2525
throws NamingException {
2626

27-
Context env = null;
28-
env = (Context)new InitialContext().lookup("java:comp/env");
27+
Context env = (Context)new InitialContext().lookup("java:comp/env");
2928
ds = (DataSource)env.lookup("jdbc/mystamps");
3029
}
3130

src/ru/mystamps/db/Users.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
public class Users {
1818
private Logger log = Logger.getRootLogger();
19-
private DataSource ds = null;
19+
private DataSource ds;
2020

2121
/**
2222
* @see add()
@@ -71,8 +71,7 @@ public class Users {
7171
public Users()
7272
throws NamingException {
7373

74-
Context env = null;
75-
env = (Context)new InitialContext().lookup("java:comp/env");
74+
Context env = (Context)new InitialContext().lookup("java:comp/env");
7675
ds = (DataSource)env.lookup("jdbc/mystamps");
7776
}
7877

src/ru/mystamps/db/UsersActivation.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
public class UsersActivation {
1616
private Logger log = Logger.getRootLogger();
17-
private DataSource ds = null;
17+
private DataSource ds;
1818

1919
/**
2020
* @see add()
@@ -44,8 +44,7 @@ public class UsersActivation {
4444
public UsersActivation()
4545
throws NamingException {
4646

47-
Context env = null;
48-
env = (Context)new InitialContext().lookup("java:comp/env");
47+
Context env = (Context)new InitialContext().lookup("java:comp/env");
4948
ds = (DataSource)env.lookup("jdbc/mystamps");
5049
}
5150

src/ru/mystamps/site/beans/SuspiciousEventBean.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@
1010

1111
public class SuspiciousEventBean {
1212

13-
private String type = null;
14-
private String page = null;
15-
private String ip = null;
16-
private String refererPage = null;
17-
private String userAgent = null;
13+
private String type;
14+
private String page;
15+
private String ip;
16+
private String refererPage;
17+
private String userAgent;
1818

1919
private Logger log = Logger.getRootLogger();
20-
private SuspiciousActivities act = null;
20+
private SuspiciousActivities act;
2121

2222
/**
2323
* @throws NamingException

src/ru/mystamps/site/beans/UserBean.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
package ru.mystamps.site.beans;
22

33
public class UserBean {
4-
private Long uid = - 1L;
5-
private String name = null;
6-
private String login = null;
4+
private Long uid = - 1L;
5+
private String name;
6+
private String login;
77

88
public void setUid(Long uid) {
99
this.uid = uid;

src/ru/mystamps/site/filters/MaintenanceFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
public class MaintenanceFilter implements Filter {
1616

17-
private FilterConfig config = null;
18-
private Logger log = null;
17+
private FilterConfig config;
18+
private Logger log;
1919
private static final String MAINTENANCE_PAGE_URL = "/maintenance.jsf";
2020

2121
@Override

0 commit comments

Comments
 (0)