-
Notifications
You must be signed in to change notification settings - Fork 26
Deprecated attribute #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The only thing I can think of for us to try and standardize is wording for the deprecation message. I don't know if it's too early for that, though. |
php/php-src#14750 might be of interest regarding samples of wording used in PHP itself. |
The placement of attributes is the scope of the coding style but the message itself... I don't think so. |
I will mark this as closed with no action needed in ~3 days unless someone from the WG objects. |
I agree this should be closed without changes but I do think there might be opportunity to add some "SHOULD"s around using attributes to specify metadata in general when available. I wonder if we could recommend people use the Maybe something like:
But that might be too general |
No action required. |
PHP now has a
#[Deprecated]
attribute. As PER-CS, do we care and are there any guidelines we should put around it, or it is out of scope? (Out of scope is fully acceptable, I just want to be explicit about it.)The text was updated successfully, but these errors were encountered: