From 6e9a54a113655ec310b5d08ea8cd61b93db55ca6 Mon Sep 17 00:00:00 2001 From: michael-grunder Date: Sat, 2 Nov 2024 15:48:32 -0700 Subject: [PATCH] Fix NULL dereference on getOption Presently this will crash ```php $redis = new Redis; $redis->connect('localhost', 6379); $redis->getOption(Redis::OPT_FAILOVER); ``` --- redis_commands.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/redis_commands.c b/redis_commands.c index 9a1dd74bb2..a0ce3b8358 100644 --- a/redis_commands.c +++ b/redis_commands.c @@ -6145,6 +6145,8 @@ void redis_getoption_handler(INTERNAL_FUNCTION_PARAMETERS, case REDIS_OPT_NULL_MBULK_AS_NULL: RETURN_LONG(redis_sock->null_mbulk_as_null); case REDIS_OPT_FAILOVER: + if (c == NULL) + RETURN_FALSE; RETURN_LONG(c->failover); case REDIS_OPT_MAX_RETRIES: RETURN_LONG(redis_sock->max_retries);