Moving datarevision incrementor to right place

andrefarzat · andrefarzat · commit c6c9b5639b4c · 2019-04-28T23:43:13.000-03:00
diff --git a/src/app/shared/plot/plot.component.ts b/src/app/shared/plot/plot.component.ts
@@ -148,7 +148,6 @@ export class PlotComponent implements OnInit, OnChanges, OnDestroy, DoCheck {
         if (this.dataDiffer) {
             const dataHasDiff = this.dataDiffer.diff(this.data);
             if (dataHasDiff) {
-                this.datarevision += 1;
                 shouldUpdate = true;
             }
         } else if (Array.isArray(this.data)) {
@@ -158,6 +157,7 @@ export class PlotComponent implements OnInit, OnChanges, OnDestroy, DoCheck {
         }
 
         if (shouldUpdate && this.plotlyInstance) {
+            this.datarevision += 1;
             this.updatePlot();
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,6 @@ export class PlotComponent implements OnInit, OnChanges, OnDestroy, DoCheck {`
`148`	`148`	`if (this.dataDiffer) {`
`149`	`149`	`const dataHasDiff = this.dataDiffer.diff(this.data);`
`150`	`150`	`if (dataHasDiff) {`
`151`		`- this.datarevision += 1;`
`152`	`151`	`shouldUpdate = true;`
`153`	`152`	`}`
`154`	`153`	`} else if (Array.isArray(this.data)) {`
`@@ -158,6 +157,7 @@ export class PlotComponent implements OnInit, OnChanges, OnDestroy, DoCheck {`
`158`	`157`	`}`
`159`	`158`
`160`	`159`	`if (shouldUpdate && this.plotlyInstance) {`
	`160`	`+ this.datarevision += 1;`
`161`	`161`	`this.updatePlot();`
`162`	`162`	`}`
`163`	`163`	`}`