turn log level 1 on by default and move zsmooth messages to logs

alexcjohnson · alexcjohnson · commit 0f8520e846f4 · 2017-12-07T20:13:38.000-05:00
diff --git a/src/plot_api/plot_config.js b/src/plot_api/plot_config.js
@@ -122,7 +122,10 @@ module.exports = {
 
     // Turn all console logging on or off (errors will be thrown)
     // This should ONLY be set via Plotly.setPlotConfig
-    logging: false,
+    // 0: no logs
+    // 1: warnings and errors, but not informational messages
+    // 2: verbose logs
+    logging: 1,
 
     // Set global transform to be applied to all traces with no
     // specification needed
diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js
@@ -382,7 +382,7 @@ module.exports = function setConvert(ax, fullLayout) {
 
         if(!isFinite(ax._m) || !isFinite(ax._b)) {
             fullLayout._replotting = false;
-            throw new Error('axis scaling');
+            throw new Error('Something went wrong with axis scaling');
         }
     };
 
diff --git a/src/traces/heatmap/calc.js b/src/traces/heatmap/calc.js
@@ -11,7 +11,6 @@
 
 var Registry = require('../../registry');
 var Lib = require('../../lib');
-var _ = Lib._;
 var Axes = require('../../plots/cartesian/axes');
 
 var histogram2dCalc = require('../histogram2d/calc');
@@ -83,21 +82,21 @@ module.exports = function calc(gd, trace) {
 
     function noZsmooth(msg) {
         zsmooth = trace._input.zsmooth = trace.zsmooth = false;
-        Lib.notifier(_(gd, 'cannot use zsmooth: "fast"') + '<br>' + msg);
+        Lib.warn('cannot use zsmooth: "fast": ' + msg);
     }
 
     // check whether we really can smooth (ie all boxes are about the same size)
     if(zsmooth === 'fast') {
         if(xa.type === 'log' || ya.type === 'log') {
-            noZsmooth(_(gd, 'log axis found'));
+            noZsmooth('log axis found');
         }
         else if(!isHist) {
             if(x.length) {
                 var avgdx = (x[x.length - 1] - x[0]) / (x.length - 1),
                     maxErrX = Math.abs(avgdx / 100);
                 for(i = 0; i < x.length - 1; i++) {
                     if(Math.abs(x[i + 1] - x[i] - avgdx) > maxErrX) {
-                        noZsmooth(_(gd, 'x scale is not linear'));
+                        noZsmooth('x scale is not linear');
                         break;
                     }
                 }
@@ -107,7 +106,7 @@ module.exports = function calc(gd, trace) {
                     maxErrY = Math.abs(avgdy / 100);
                 for(i = 0; i < y.length - 1; i++) {
                     if(Math.abs(y[i + 1] - y[i] - avgdy) > maxErrY) {
-                        noZsmooth(_(gd, 'y scale is not linear'));
+                        noZsmooth('y scale is not linear');
                         break;
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -382,7 +382,7 @@ module.exports = function setConvert(ax, fullLayout) {`
`382`	`382`
`383`	`383`	`if(!isFinite(ax._m) \|\| !isFinite(ax._b)) {`
`384`	`384`	`fullLayout._replotting = false;`
`385`		`- throw new Error('axis scaling');`
	`385`	`+ throw new Error('Something went wrong with axis scaling');`
`386`	`386`	`}`
`387`	`387`	`};`
`388`	`388`