Skip to content

Commit 13a3773

Browse files
authored
Merge pull request #6150 from plotly/revise-extra-bundles
Revise extra bundles creation
2 parents 27998d1 + 657c08b commit 13a3773

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"use-draftlogs": "node tasks/use_draftlogs.js",
3333
"empty-draftlogs": "node tasks/empty_draftlogs.js",
3434
"empty-dist": "node tasks/empty_dist.js",
35-
"build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles basic && npm run extra-bundles cartesian && npm run extra-bundles geo && npm run extra-bundles gl2d && npm run extra-bundles gl3d && npm run extra-bundles mapbox && npm run extra-bundles finance && npm run locales && npm run schema dist && npm run stats",
35+
"build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles && npm run locales && npm run schema dist && npm run stats",
3636
"regl-codegen": "node devtools/regl_codegen/server.js",
3737
"cibuild": "npm run empty-dist && npm run preprocess && node tasks/cibundle.js",
3838
"watch": "node tasks/watch.js",

tasks/bundle.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ tasks.push(function(done) {
5050
standalone: 'Plotly',
5151
pathToMinBundle: pathToPlotlyStrictDistMin
5252
}, function() {
53-
prependFile.sync(pathToPlotlyStrictDist, header, common.throwOnError);
54-
prependFile.sync(pathToPlotlyStrictDistMin, header, common.throwOnError);
53+
prependFile.sync(pathToPlotlyStrictDist, header.replace('plotly.js', 'plotly.js (strict)'), common.throwOnError);
54+
prependFile.sync(pathToPlotlyStrictDistMin, header.replace('plotly.js', 'plotly.js (strict - minified)'), common.throwOnError);
5555

5656
done();
5757
});

tasks/extra_bundles.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ var tasks = [];
3030
for(var i = 0; i < list.length; i++) {
3131
var opts = list[i];
3232

33+
// strict bundle is no longer a partial bundle and generated with bundles
34+
if(opts.name === 'strict') continue;
35+
3336
partialBundle(tasks, {
3437
name: opts.name,
3538
index: opts.index,

0 commit comments

Comments
 (0)