eschewing convertToTspans if not need (though: formatting is now lost)

monfera · monfera · commit 4e5bcf6adb51 · 2017-09-30T12:08:32.000+02:00
diff --git a/src/traces/table/plot.js b/src/traces/table/plot.js
@@ -429,6 +429,7 @@ function renderCellText(cellText, tableControlView, allColumnBlock, columnCell,
             var format = latex ? null : gridPick(d.calcdata.cells.format, col, row) || null;
             var prefixSuffixedText = prefix + (format ? d3.format(format)(d.value) : d.value) + suffix;
             d.latex = latex;
+            d.mayHaveMarkup = (typeof userSuppliedContent === 'string') && userSuppliedContent.match(/[<>]/);
             var hasWrapSplitCharacter;
             var hwsc = function(prefixSuffixedText) {return prefixSuffixedText.indexOf(c.wrapSplitCharacter) !== -1;};
             d.wrappingNeeded = !d.wrapped && !userBrokenText && !latex && (hasWrapSplitCharacter = hwsc(prefixSuffixedText));
@@ -460,7 +461,11 @@ function renderCellText(cellText, tableControlView, allColumnBlock, columnCell,
             Drawing.font(selection, d.font);
 
             var renderCallback = d.wrappingNeeded ? wrapTextMaker : updateYPositionMaker;
-            svgUtil.convertToTspans(selection, gd, renderCallback(allColumnBlock, element, tableControlView, d));
+            if(d.mayHaveMarkup || d.wrappingNeeded || d.latex) {
+                svgUtil.convertToTspans(selection, gd, renderCallback(allColumnBlock, element, tableControlView, d));
+            } else {
+                // renderCallback(allColumnBlock, element, tableControlView, d);
+            }
         })
         columnCell.call(setCellHeightAndPositionY);
 }
diff --git a/test/image/mocks/table_one_cell.json b/test/image/mocks/table_one_cell.json
@@ -67,8 +67,8 @@
         "cells": {
 
             "values": [
-                Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),
-                Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),
+                Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),
+                Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),
             ]
             .slice(0, 20) || [
                 [

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,8 @@`
`67`	`67`	`"cells": {`
`68`	`68`
`69`	`69`	`"values": [`
`70`		`- Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),`
`71`		`- Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),Array.from(Array(100).keys()),`
	`70`	`+ Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),`
	`71`	`+ Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),Array.from(Array(1000).keys()),`
`72`	`72`	`]`
`73`	`73`	`.slice(0, 20) \|\| [`
`74`	`74`	`[`