Skip to content

Commit b28052b

Browse files
committed
clean splom drag logic
1 parent ce379a1 commit b28052b

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

src/traces/splom/base_plot.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,9 @@ function drag(gd) {
4242
var trace = cd0.trace;
4343
var scene = cd0.t._scene;
4444

45-
// FIXME: this probably should not be called for non-splom traces
46-
if(!scene || !scene.matrixOptions) continue;
47-
48-
var opts = scene.matrixOptions;
49-
5045
if(trace.type === 'splom' && scene && scene.matrix) {
5146
var activeLength = trace._activeLength;
52-
var visibleLength = opts.data.length;
47+
var visibleLength = scene.matrixOptions.data.length;
5348
var ranges = new Array(visibleLength);
5449
var k = 0;
5550

@@ -72,7 +67,7 @@ function drag(gd) {
7267
}
7368

7469
if(fullLayout._hasOnlyLargeSploms) {
75-
fullLayout._modules[0].basePlotModule.drawGrid(gd);
70+
drawGrid(gd);
7671
}
7772
}
7873

@@ -233,7 +228,7 @@ module.exports = {
233228
drawFramework: Cartesian.drawFramework,
234229
plot: plot,
235230
drag: drag,
236-
drawGrid: drawGrid,
237231
clean: clean,
232+
updateFx: Cartesian.updateFx,
238233
toSVG: Cartesian.toSVG
239234
};

0 commit comments

Comments
 (0)