bar: skip over bars with non-numeric size in setPositions

etpinard · etpinard · commit b7f794485c2d · 2016-07-05T13:58:03.000-04:00
- before dd2251d bar for non-numeric size were excluded from the calcdata, which led to wrong bar widths in traces with gaps. However, this made setPositions stack non-numeric bars.
diff --git a/src/traces/bar/calc.js b/src/traces/bar/calc.js
@@ -39,7 +39,13 @@ module.exports = function calc(gd, trace) {
     // create the "calculated data" to plot
     var serieslen = Math.min(pos.length, size.length),
         cd = [];
+
     for(i = 0; i < serieslen; i++) {
+
+        // add bars with non-numeric sizes to calcdata
+        // so that ensure that traces with gaps are
+        // plotted in the correct order
+
         if(isNumeric(pos[i])) {
             cd.push({p: pos[i], s: size[i], b: 0});
         }
diff --git a/src/traces/bar/set_positions.js b/src/traces/bar/set_positions.js
@@ -142,6 +142,11 @@ module.exports = function setPositions(gd, plotinfo) {
             for(i = 0; i < bl.length; i++) { // trace index
                 ti = gd.calcdata[bl[i]];
                 for(j = 0; j < ti.length; j++) {
+
+                    // skip over bars with no size,
+                    // so that we don't try to stack them
+                    if(!isNumeric(ti[j].s)) continue;
+
                     sv = Math.round(ti[j].p / sumround);
                     // store the negative sum value for p at the same key, with sign flipped
                     if(relative && ti[j].s < 0) sv = -sv;
