Skip to content

Commit c252e17

Browse files
committed
reshuffling
1 parent 940a41d commit c252e17

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/traces/table/plot.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -745,13 +745,12 @@ function updateYPositionMaker(columnBlock, element, tableControlView, d) {
745745
}
746746

747747
function setCellHeightAndPositionY(columnCell) {
748-
// fixme second perf bottleneck
749748
columnCell
750749
.attr('transform', function(d) {
750+
var headerHeight = d.rowBlocks[0].auxiliaryBlocks.reduce(function(p, n) {return p + rowsHeight(n, Infinity)}, 0);
751751
var l = getBlock(d);
752752
var rowAnchor = rowsHeight(l, d.key);
753753
var rowOffset = firstRowAnchor(d.rowBlocks, l.key) + rowAnchor - firstRowAnchor(d.rowBlocks, d.page);
754-
var headerHeight = d.rowBlocks[0].auxiliaryBlocks.reduce(function(p, n) {return p + rowsHeight(n, Infinity)}, 0);
755754
var yOffset = rowOffset + headerHeight;
756755
return 'translate(0 ' + yOffset + ')';
757756
})
@@ -761,7 +760,7 @@ function setCellHeightAndPositionY(columnCell) {
761760

762761
function firstRowAnchor(blocks, p) {
763762
var pTop = 0;
764-
for(var i = 0; i <= p - 1; i++) {
763+
for(var i = 0; i < p; i++) {
765764
pTop += rowsHeight(blocks[i], Infinity);
766765
}
767766
return pTop;

0 commit comments

Comments
 (0)