Skip to content

This cone trace with sizemode: 'absolute' punches through scene wall #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
etpinard opened this issue Jun 6, 2018 · 0 comments · Fixed by #2715
Closed

This cone trace with sizemode: 'absolute' punches through scene wall #2700

etpinard opened this issue Jun 6, 2018 · 0 comments · Fixed by #2715
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

etpinard commented Jun 6, 2018

See https://codepen.io/etpinard/pen/mKEoro?editors=0010

this should not happen. Something must be wrong with how we add autorange pads here for sizemode: 'absolute':

plotly.js/src/traces/cone/convert.js

Lines 111 to 113 in ece927f

// stash autorange pad value
trace._pad = anchor2coneSpan[trace.anchor] * meshData.vectorScale * trace.sizeref;
if(trace.sizemode === 'scaled') trace._pad *= trace._normMax;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cone sizeref fixes plotly/plotly.js
1 participant
@etpinard