Skip to content

scattergl & fill #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ErwanMAS opened this issue Sep 19, 2018 · 3 comments
Closed

scattergl & fill #3025

ErwanMAS opened this issue Sep 19, 2018 · 3 comments

Comments

@ErwanMAS
Copy link
Contributor

ErwanMAS commented Sep 19, 2018

Please look .

https://codepen.io/erwanmas/pen/dqQrbR

The issue is generated by https://github.com/mapbox/earcut in https://github.com/a-vis/regl-line2d . AND earcut doesn't guarantee correctness

https://github.com/mapbox/earcut/blob/master/README.md

a simple console.log here https://github.com/a-vis/regl-line2d/blob/b9d56d51e1598c4ee7a9a5e0a733e920daf63c2d/index.js#L520 will output only 1 triangle , instead of 2 triangles

@etpinard
Copy link
Contributor

Thanks for the very clear example 🔬

I merged your ticket into #2291 (comment), which also discusses scattergl fill toself issues.

@ErwanMAS
Copy link
Contributor Author

This not specific to fill:toself , you have the same issue with fill:tozerox and for fill:tozeroy

@etpinard
Copy link
Contributor

cc #2284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants