Skip to content

Error fetching geojson when ES6 import is used #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue Jun 21, 2021 · 4 comments · Fixed by #5763
Closed

Error fetching geojson when ES6 import is used #5753

archmoj opened this issue Jun 21, 2021 · 4 comments · Fixed by #5763
Labels
bug something broken
Milestone
v2.2.0

Comments

@archmoj
Copy link
Contributor

archmoj commented Jun 21, 2021

codepen
See console error.
@archmoj archmoj added the bug something broken label Jun 21, 2021
@archmoj
Copy link
Contributor Author

archmoj commented Jun 21, 2021

Replacing this.XDomainRequest with self.XDomainRequest in d3-v3 fork appears to fix the problem.

@nicolaskruchten
Copy link
Contributor

Is this to do with the changes we made to make things ES6-importable? Maybe there's a binding problem now?

@archmoj
Copy link
Contributor Author

archmoj commented Jun 21, 2021

It does not look like a regression.
Only that right now everything is not E6 importable.

@archmoj
Copy link
Contributor Author

archmoj commented Jun 21, 2021

I only see the error in choropleth when using test_dashboard that uses es6-import.

@archmoj archmoj added this to the NEXT milestone Jun 23, 2021
@archmoj archmoj mentioned this issue Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Fix fetching geojson when ES6 import is used to load the library plotly/plotly.js
2 participants
@nicolaskruchten @archmoj