-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
document the structure of trace modules #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the gl trace modules need a |
I'll try to make a PR for this ticket before I go. @archmoj is there anything in particular regarding the trace module structure that you'd like me to write on? |
It would be helpful to know "when each of them gets called". |
TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivated by #63 ... we should describe this structure somewhere in the contributor's guide. What's generally supposed to be the role of
attributes
,supplyDefaults
,supplyLayoutDefaults
,calc
,setPositions
,plot
, andstyle
(anything else?), how to tell the difference, and when each of them gets called. Without that it's pretty hard for new people to make any meaningful contributions to the drawing code. The non-trace modules (axes, annotations, etc...) may still be too ad-hoc for this kind of doc to be useful, but I think the traces are fairly uniform by now.Of course if this leads us to the desperately needed refactor & modularization of
restyle
andrelayout
I wouldn't complain, but that shouldn't stop us from documenting what we have.The text was updated successfully, but these errors were encountered: