diff --git a/package-lock.json b/package-lock.json index 4c7f3dfea92..e563ecbc07f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4498,9 +4498,9 @@ } }, "gl-axes3d": { - "version": "1.4.0", - "resolved": "https://registry.npmjs.org/gl-axes3d/-/gl-axes3d-1.4.0.tgz", - "integrity": "sha512-aakup65ywK7Bo0k/2IAq8AdvtZYHJANskePJpElcmuC1vm0l+4sRKmXevdR9AYBDNh5KEULFSnTe9RHVPvBtxQ==", + "version": "1.4.2", + "resolved": "https://registry.npmjs.org/gl-axes3d/-/gl-axes3d-1.4.2.tgz", + "integrity": "sha512-gDqYKiMYEUpF6DQ7i7qrRkI09c5DUdQLG75rDDO3bPZA57XDCh7DqbQCdyBzxSqOCOSF9v53mSI/dlmM3bzuEQ==", "requires": { "bit-twiddle": "^1.0.0", "dup": "^1.0.0", @@ -4704,13 +4704,13 @@ } }, "gl-plot3d": { - "version": "1.6.0", - "resolved": "https://registry.npmjs.org/gl-plot3d/-/gl-plot3d-1.6.0.tgz", - "integrity": "sha512-SWUXVuWlBE+GIQWysB5HmoqBDkkaCydT8JJl5CWyApau3bTtHzEEafMEBBfkc4THmk/3YXgmjmSlXF5vefTo/g==", + "version": "1.6.1", + "resolved": "https://registry.npmjs.org/gl-plot3d/-/gl-plot3d-1.6.1.tgz", + "integrity": "sha512-w93IiAm1xM+VIRunFs6opcLIgnbrdCSg9Lfg4jLp7m3e3qHCn3LyUCrG8qT1qW2HMLje9dCWnZmZyMb7Vbx24g==", "requires": { "3d-view-controls": "^2.2.0", "a-big-triangle": "^1.0.0", - "gl-axes3d": "^1.4.0", + "gl-axes3d": "^1.4.2", "gl-fbo": "^2.0.3", "gl-mat4": "^1.1.2", "gl-select-static": "^2.0.2", @@ -4803,9 +4803,9 @@ "integrity": "sha1-ys2y09vNICuFNFLoUAqLB3lJzAM=" }, "gl-spikes3d": { - "version": "1.0.6", - "resolved": "https://registry.npmjs.org/gl-spikes3d/-/gl-spikes3d-1.0.6.tgz", - "integrity": "sha512-mXRG+3iCs4bDH7if2aOr1G5UpbNqKxfWpy7GR/afOHDSNsrq2ZjnWAwPmIJG7KdClPNPgiK30cVo7XisLt8PCQ==", + "version": "1.0.7", + "resolved": "https://registry.npmjs.org/gl-spikes3d/-/gl-spikes3d-1.0.7.tgz", + "integrity": "sha512-i/JW5kqAGUSSvPhypDpCc5dBBaT2NkgqEmNAjpaepQrBvxQ9qKBn3jpywGMsPhVBUbEWb626BDSfmoe84bE0TQ==", "requires": { "gl-buffer": "^2.1.2", "gl-shader": "^4.0.4", diff --git a/package.json b/package.json index f55ac120e16..c12c01fa678 100644 --- a/package.json +++ b/package.json @@ -78,7 +78,7 @@ "gl-mat4": "^1.2.0", "gl-mesh3d": "^2.0.2", "gl-plot2d": "^1.4.0", - "gl-plot3d": "^1.6.0", + "gl-plot3d": "^1.6.1", "gl-pointcloud2d": "^1.0.1", "gl-scatter3d": "^1.1.0", "gl-select-box": "^1.0.2", diff --git a/test/image/baselines/gl3d_perspective_tick_distances.png b/test/image/baselines/gl3d_perspective_tick_distances.png new file mode 100644 index 00000000000..7c007c341f8 Binary files /dev/null and b/test/image/baselines/gl3d_perspective_tick_distances.png differ diff --git a/test/image/mocks/gl3d_perspective_tick_distances.json b/test/image/mocks/gl3d_perspective_tick_distances.json new file mode 100644 index 00000000000..bf71c7c53b6 --- /dev/null +++ b/test/image/mocks/gl3d_perspective_tick_distances.json @@ -0,0 +1,29 @@ +{ + "data":[ + { + "type": "surface", + "contours": { + "x": {"show": true}, + "y": {"show": true}, + "z": {"show": false} + }, + "x": [0, 4], + "y": [0, 1, 2, 3, 4], + "z": [[0, 0], [0, 0], [0, 1], [1, 1], [1, 1]] + } + ], + "layout": { + "title": "Tick distances and contour lines in perspective view.", + "width": 1000, + "height": 500, + "scene": { + "xaxis": {"nticks": 32}, + "yaxis": {"nticks": 32}, + "camera": { + "center": {"x": 0, "y": 0.25, "z": 0.0}, + "eye": {"x": 0.75, "y": 0.25, "z": 0.25}, + "up": {"x": 0, "y": 0, "z": 1} + } + } + } +} diff --git a/test/jasmine/tests/gl3d_plot_interact_test.js b/test/jasmine/tests/gl3d_plot_interact_test.js index 0031d74375d..6b1ee42c3e4 100644 --- a/test/jasmine/tests/gl3d_plot_interact_test.js +++ b/test/jasmine/tests/gl3d_plot_interact_test.js @@ -714,7 +714,7 @@ describe('Test gl3d plots', function() { .then(done); }); - it('@gl axis ticks should not be set when axis _length is NaN', function(done) { + it('@gl should not set _length to NaN and dtick should be defined.', function(done) { Plotly.plot(gd, { data: [{ @@ -722,7 +722,7 @@ describe('Test gl3d plots', function() { mode: 'markers', x: [1, 2], y: [3, 4], - z: [5, 6] + z: [0.000000005, 0.000000006] }], layout: { scene: { @@ -737,8 +737,8 @@ describe('Test gl3d plots', function() { ) .then(function() { var zaxis = gd._fullLayout.scene.zaxis; - expect(isNaN(zaxis._length)).toBe(true); - expect(zaxis.dtick === undefined).toBe(true); + expect(isNaN(zaxis._length)).toBe(false); + expect(zaxis.dtick === undefined).toBe(false); }) .catch(failTest) .then(done);