From 8f75d0b52c4be1c0cabe35921a0cde7d74063cda Mon Sep 17 00:00:00 2001 From: mikolalysenko Date: Thu, 26 May 2016 16:42:15 -0700 Subject: [PATCH 1/2] fix gl2d snapshot rendering --- src/plots/gl2d/index.js | 11 +++++------ src/plots/gl3d/scene.js | 5 +++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/plots/gl2d/index.js b/src/plots/gl2d/index.js index 5fd16a5bb3a..eb12013558e 100644 --- a/src/plots/gl2d/index.js +++ b/src/plots/gl2d/index.js @@ -86,8 +86,7 @@ exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout) exports.toSVG = function(gd) { var fullLayout = gd._fullLayout, - subplotIds = Plots.getSubplotIds(fullLayout, 'gl2d'), - size = fullLayout._size; + subplotIds = Plots.getSubplotIds(fullLayout, 'gl2d'); for(var i = 0; i < subplotIds.length; i++) { var subplot = fullLayout._plots[subplotIds[i]], @@ -99,10 +98,10 @@ exports.toSVG = function(gd) { image.attr({ xmlns: xmlnsNamespaces.svg, 'xlink:href': imageData, - x: size.l, - y: size.t, - width: size.w, - height: size.h, + x: 0, + y: 0, + width: '100%', + height: '100%', preserveAspectRatio: 'none' }); diff --git a/src/plots/gl3d/scene.js b/src/plots/gl3d/scene.js index a58c39eab10..3465ee9cdd2 100644 --- a/src/plots/gl3d/scene.js +++ b/src/plots/gl3d/scene.js @@ -147,7 +147,8 @@ function initializeGLPlot(scene, fullLayout, canvas, gl) { try { STATIC_CONTEXT = STATIC_CANVAS.getContext('webgl', { preserveDrawingBuffer: true, - premultipliedAlpha: true + premultipliedAlpha: true, + antialias: true }); } catch(e) { throw new Error('error creating static canvas/context for image server'); @@ -183,7 +184,7 @@ function initializeGLPlot(scene, fullLayout, canvas, gl) { if(!scene.staticMode) { scene.glplot.canvas.addEventListener('webglcontextlost', function(ev) { - Lib.warn('Lost WebGL context.'); + Lib.warn('Lost WebGL context.'); ev.preventDefault(); }); } From b0ecf2e757bc6d960f092e8fbe71e06cdee5dd8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Mon, 11 Jul 2016 14:15:45 -0400 Subject: [PATCH 2/2] lint --- src/plots/gl3d/scene.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plots/gl3d/scene.js b/src/plots/gl3d/scene.js index 3465ee9cdd2..f799c40543b 100644 --- a/src/plots/gl3d/scene.js +++ b/src/plots/gl3d/scene.js @@ -184,7 +184,7 @@ function initializeGLPlot(scene, fullLayout, canvas, gl) { if(!scene.staticMode) { scene.glplot.canvas.addEventListener('webglcontextlost', function(ev) { - Lib.warn('Lost WebGL context.'); + Lib.warn('Lost WebGL context.'); ev.preventDefault(); }); }