From 16d614a4082c0721d41460f445adbdc255911edc Mon Sep 17 00:00:00 2001 From: asifhaider <1805112@ugrad.cse.buet.ac.bd> Date: Sun, 3 Dec 2023 04:42:20 +0600 Subject: [PATCH 1/3] Fixed Inappropriate Logical Expression --- packages/python/plotly/plotly/express/_core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py index 6f3d55dc5c9..22ea56c25a0 100644 --- a/packages/python/plotly/plotly/express/_core.py +++ b/packages/python/plotly/plotly/express/_core.py @@ -1131,7 +1131,7 @@ def process_args_into_dataframe(args, wide_mode, var_name, value_name): else args.get(field_name) ) # argument not specified, continue - if argument_list is None or argument_list is [None]: + if argument_list is None or argument_list == [None]: continue # Argument name: field_name if the argument is not a list # Else we give names like ["hover_data_0, hover_data_1"] etc. From 999c636cbac8d22a34b4be9f8be1be63895bfbaa Mon Sep 17 00:00:00 2001 From: asifhaider <1805112@ugrad.cse.buet.ac.bd> Date: Fri, 8 Dec 2023 09:09:55 +0600 Subject: [PATCH 2/3] Fixed inappropriate logical expression (edited) --- packages/python/plotly/plotly/express/_core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py index 22ea56c25a0..eb132633298 100644 --- a/packages/python/plotly/plotly/express/_core.py +++ b/packages/python/plotly/plotly/express/_core.py @@ -1131,7 +1131,7 @@ def process_args_into_dataframe(args, wide_mode, var_name, value_name): else args.get(field_name) ) # argument not specified, continue - if argument_list is None or argument_list == [None]: + if argument_list is None or (len(argument_list) == 1 and argument_list[0] is None): continue # Argument name: field_name if the argument is not a list # Else we give names like ["hover_data_0, hover_data_1"] etc. From a94e2d8542b5ccb3b2ec69d8afdf61ce5ee3a736 Mon Sep 17 00:00:00 2001 From: asifhaider <1805112@ugrad.cse.buet.ac.bd> Date: Fri, 8 Dec 2023 09:14:09 +0600 Subject: [PATCH 3/3] Revert "Fixed inappropriate logical expression (edited)" This reverts commit 999c636cbac8d22a34b4be9f8be1be63895bfbaa. --- packages/python/plotly/plotly/express/_core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py index eb132633298..22ea56c25a0 100644 --- a/packages/python/plotly/plotly/express/_core.py +++ b/packages/python/plotly/plotly/express/_core.py @@ -1131,7 +1131,7 @@ def process_args_into_dataframe(args, wide_mode, var_name, value_name): else args.get(field_name) ) # argument not specified, continue - if argument_list is None or (len(argument_list) == 1 and argument_list[0] is None): + if argument_list is None or argument_list == [None]: continue # Argument name: field_name if the argument is not a list # Else we give names like ["hover_data_0, hover_data_1"] etc.