Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: plotly/plotly.rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 34f86fc
Choose a base ref
...
head repository: plotly/plotly.rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e0afa36
Choose a head ref
  • 8 commits
  • 10 files changed
  • 3 contributors

Commits on Sep 6, 2024

  1. Make Bar.width to be Option<f64> (#230)

    * Make Bar.width to be Option<f64>
    
    * make bar offset float as well
    
    - update test
    
    Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
    
    ---------
    
    Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
    Co-authored-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
    Ionizing and andrei-ng authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7bfae55 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Add 'plotly_noembed' cargo feature

    This adds a new `plotly_noembed` feature that can be used to reduce the
    sizes of binaries by not embedding `plotly.min.js`.
    
    Since askama can not handle compile-time flags, we had to duplicate the
    `plot.html` and `static_plot.html` templates, where the new
    `*_noembed.html` version only contains the CDN-variant.
    
    The `use_local_plotly` option has been feature-gated such that it is
    not available when using the new feature.
    
    I verified that this works by building an application that depends on
    plotly.rs (including optimization and LTO in all cases):
    
        no plotly:   4.96 MiB (5,201,920 bytes)
        master:      8.96 MiB (9,400,320 bytes)
        this branch: 5.44 MiB (5,701,632 bytes)
    
    The difference between this branch and master is 3,698,688 bytes, which
    is very close to the size of `plotly.min.js` (3,686,400 bytes). Just as
    expected.
    David Peter authored and andrei-ng committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e3052a5 View commit details
    Browse the repository at this point in the history
  2. make embedded plotly.js as opt-in via feature flag

    Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
    andrei-ng committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1fe6f11 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #231 from sharkdp/add-no_embed-feature

    Add 'plotly_noembed' cargo feature
    andrei-ng authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cfa7bc3 View commit details
    Browse the repository at this point in the history
  4. update changelog

    Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
    andrei-ng committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    491ba79 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #235 from plotly/develop

    update changelog
    andrei-ng authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5d265b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. bump version number

    Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
    andrei-ng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a33095a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #236 from plotly/develop

    bump version number
    andrei-ng authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e0afa36 View commit details
    Browse the repository at this point in the history
Loading