Refactor UpdateErrorbar

robertoffmoura · robertoffmoura · commit 771b904b1d1e · 2025-04-07T12:11:16.000+01:00
diff --git a/plotly/Test_plotlyfig.m b/plotly/Test_plotlyfig.m
@@ -967,7 +967,7 @@ function testErrorbarData(tc)
                 "showlegend", false, ...
                 "error_y", struct( ...
                     "visible", true, ...
-                    "type", 'data', ...
+                    "type", "data", ...
                     "symmetric", false, ...
                     "array", err, ...
                     "arrayminus", err, ...
@@ -977,7 +977,7 @@ function testErrorbarData(tc)
                 ), ...
                 "error_x", struct( ...
                     "visible", true, ...
-                    "type", 'data', ...
+                    "type", "data", ...
                     "array", zeros(1,0), ...
                     "arrayminus", zeros(1,0), ...
                     "thickness", 0.5, ...
diff --git a/plotly/plotlyfig_aux/core/updateData.m b/plotly/plotlyfig_aux/core/updateData.m
@@ -125,7 +125,7 @@
             case "functioncontour"
                 obj.data{dataIndex} = updateFunctionContour(obj,dataIndex);
             case "errorbar"
-                updateErrorbar(obj,dataIndex);
+                obj.data{dataIndex} = updateErrorbar(obj,dataIndex);
             case "errorbarseries"
                 updateErrorbarseries(obj,dataIndex);
             case "lineseries"
diff --git a/plotly/plotlyfig_aux/handlegraphics/updateErrorbar.m b/plotly/plotlyfig_aux/handlegraphics/updateErrorbar.m
@@ -1,39 +1,28 @@
-function obj = updateErrorbar(obj, plotIndex)
-	%-INITIALIZATION-%
-
+function data = updateErrorbar(obj, plotIndex)
 	%-get data structures-%
 	plotData = obj.State.Plot(plotIndex).Handle;
 
-	%-get error data-%
-	yPositiveDelta = plotData.YPositiveDelta;
-	yNegativeDelta = plotData.YNegativeDelta;
-
-	xPositiveDelta = plotData.XPositiveDelta;
-	xNegativeDelta = plotData.XNegativeDelta;
-
 	%-set trace-%
-	obj.data{plotIndex} = updateLineseries(obj, plotIndex);
-
-	obj.data{plotIndex}.error_y.visible = true;
-	obj.data{plotIndex}.error_x.visible = true;
-	obj.data{plotIndex}.error_y.type = 'data';
-	obj.data{plotIndex}.error_x.type = 'data';
-
-	obj.data{plotIndex}.error_y.symmetric = false;
-
-	obj.data{plotIndex}.error_y.array = yPositiveDelta;
-	obj.data{plotIndex}.error_x.array = xPositiveDelta;
-	obj.data{plotIndex}.error_x.arrayminus = xNegativeDelta;
-	obj.data{plotIndex}.error_y.arrayminus = yNegativeDelta;
-
-	obj.data{plotIndex}.error_y.thickness = plotData.LineWidth;
-	obj.data{plotIndex}.error_x.thickness = plotData.LineWidth;
-
-	obj.data{plotIndex}.error_y.width = obj.PlotlyDefaults.ErrorbarWidth;
-	obj.data{plotIndex}.error_x.width = obj.PlotlyDefaults.ErrorbarWidth;
-
-	%-errorbar color-%
-	errorColor = getStringColor(round(255*plotData.Color));
-	obj.data{plotIndex}.error_y.color = errorColor;
-	obj.data{plotIndex}.error_x.color = errorColor;
+	data = updateLineseries(obj, plotIndex);
+
+	data.error_y = struct( ...
+		"visible", true, ...
+		"type", "data", ...
+		"array", plotData.YPositiveDelta, ...
+		"arrayminus", plotData.YNegativeDelta, ...
+		"thickness", plotData.LineWidth, ...
+		"width", obj.PlotlyDefaults.ErrorbarWidth, ...
+		"color", getStringColor(round(255*plotData.Color)), ...
+		"symmetric", false ...
+	);
+
+	data.error_x = struct( ...
+		"visible", true, ...
+		"type", "data", ...
+		"array", plotData.XPositiveDelta, ...
+		"arrayminus", plotData.XNegativeDelta, ...
+		"thickness", plotData.LineWidth, ...
+		"width", obj.PlotlyDefaults.ErrorbarWidth, ...
+		"color", getStringColor(round(255*plotData.Color)) ...
+	);
 end
