Merge pull request davidbombal#2 from monovon/patch-1

davidbombal · web-flow · commit 8ae5b1009d75 · 2021-04-21T15:38:00.000+02:00
Fix: Edited the text.
diff --git a/windows10-wifi.py b/windows10-wifi.py
@@ -4,60 +4,70 @@
 #https://www.youtube.com/davidbombal #
 ######################################
 
-# Import subprocess so we can use system commands
+#    Import subprocess so we can use system commands.
 import subprocess
 
-# Import the re module so that we can make use of regular expressions. 
+#    Import the re module so we can make use of regular expressions. 
 import re
 
-# Python allows us to run system commands by using a function provided by the subprocess module 
-# (subprocess.run(<list of command line arguments goes here>, <specify the second argument if you want to capture the output>))
-# The script is a parent process and creates a child process which runs the system command, 
-# and will only continue once the child process has completed.
-# To save the contents that gets sent to the standard output stream (the terminal) 
-# we have to specify that we want to capture the output, 
-# so we specify the second argument as capture_output = True. 
-# This information gets stored in the stdout attribute. 
-# The information is stored in bytes and we need to decode it to Unicode 
-# before we use it as a String in Python.
+#    Python allows us to run system commands using the function 
+#    provided by the subprocess module; 
+#    (subprocess.run(<list of command line arguments go here>, <specify the second argument if you want to capture the output>)).
+#
+#    This script is a parent process that creates a child process which 
+#    runs a system command and will only continue once the child process 
+#    is completed. 
+#
+#    To save the contents that get sent to the standard output stream 
+#    (the terminal), we must first specify that we want to capture the output.
+#    To do this we specify the second argument as capture_output = True. 
+#    This information gets stored in the stdout attribute as bytes and 
+#    needs to be decoded before being used as a String in Python.
 command_output = subprocess.run(["netsh", "wlan", "show", "profiles"], capture_output = True).stdout.decode()
 
-# We imported the re module so that we can make use of regular expressions. 
-# We want to find all the Wifi names which is always listed after "ALL User Profile     :". 
-# In the regular expression we create a group of all characters until the return escape sequence (\r) appears.
+#    We imported the re module to make use of regular expressions. 
+#    We want to find all the wifi names which are listed after 
+#    "ALL User Profile     :". Using regular expressions we can create 
+#    a group of all characters until the return escape sequence (\r) appears.
 profile_names = (re.findall("All User Profile     : (.*)\r", command_output))
 
-# We create an empty list outside of the loop where dictionaries with all the wifi 
-# username and passwords will be saved.
-wifi_list = list()
+#    We create an empty list outside of the loop where dictionaries 
+#    containing all the wifi usernames and passwords will be saved.
+wifi_list = []
 
-# If we didn't find profile names we didn't have any wifi connections, 
-# so we only run the part to check for the details of the wifi and 
-# whether we can get their passwords in this part.
+#    If any profile names are not found this means that wifi connections 
+#    have also not been found. So we run this part to check the 
+#    details of the wifi and see whether we can get their passwords.
 if len(profile_names) != 0:
     for name in profile_names:
-        # Every wifi connection will need its own dictionary which will be appended to the wifi_list
-        wifi_profile = dict()
-        # We now run a more specific command to see the information about the specific wifi connection 
-        # and if the Security key is not absent we can possibly get the password.
+        #    Every wifi connection will need its own dictionary which 
+        #    will be appended to the variable wifi_list.
+        wifi_profile = {}
+        #    We can now run a more specific command to see the information 
+        #    about the wifi connection and if the Security key
+        #    is not absent it may be possible to get the password.
         profile_info = subprocess.run(["netsh", "wlan", "show", "profile", name], capture_output = True).stdout.decode()
-        # We use a regular expression to only look for the absent cases so we can ignore them.
+        #    We use the regular expression to only look for the absent cases so we can ignore them.
         if re.search("Security key           : Absent", profile_info):
             continue
         else:
-            # Assign the ssid of the wifi profile to the dictionary
+            #    Assign the ssid of the wifi profile to the dictionary.
             wifi_profile["ssid"] = name
-            # These cases aren't absent and we should run them "key=clear" command part to get the password
+            #    These cases aren't absent and we should run the 
+            #    "key=clear" command part to get the password.
             profile_info_pass = subprocess.run(["netsh", "wlan", "show", "profile", name, "key=clear"], capture_output = True).stdout.decode()
-            # Again run the regular expressions to capture the group after the : which is the password
+            #    Again run the regular expression to capture the 
+            #    group after the : (which is the password).
             password = re.search("Key Content            : (.*)\r", profile_info_pass)
-            # Check if we found a password in the regular expression. All wifi connections will not have passwords.
+            #    Check if we found a password using the regular expression. 
+            #    Some wifi connections may not have passwords.
             if password == None:
                 wifi_profile["password"] = None
             else:
-                # We assign the grouping (Where the password is contained) we are interested to the password key in the dictionary.
+                #    We assign the grouping (where the password is contained) that 
+                #    we are interested in to the password key in the dictionary.
                 wifi_profile["password"] = password[1]
-            # We append the wifi information to the wifi_list
+            #    We append the wifi information to the variable wifi_list.
             wifi_list.append(wifi_profile) 
 
 for x in range(len(wifi_list)):
