BUG19170287: Fix duplicate section error with Python v3

peeyushgupta · peeyushgupta · commit 0b951988415f · 2014-08-06T19:02:14.000+05:30
When an option file containing duplicate section was read
by connector python, a DuplcateSectionError was being raised
with Python v3. This patch fixes the issue by using parameter
strict=False while instantiating ConfigParser with Python v3.

A unit test has been added for BUG#19170287.
diff --git a/lib/mysql/connector/optionfiles.py b/lib/mysql/connector/optionfiles.py
@@ -67,7 +67,11 @@ def __init__(self, files=None, keep_dashes=True):  # pylint: disable=W0231
 
         self._options_dict = {}
 
-        SafeConfigParser.__init__(self)
+        if PY2:
+            SafeConfigParser.__init__(self)
+        else:
+            SafeConfigParser.__init__(self, strict=False)
+
         self.default_extension = DEFAULT_EXTENSIONS[os.name]
         self.keep_dashes = keep_dashes
 
diff --git a/tests/data/option_files/dup_groups.cnf b/tests/data/option_files/dup_groups.cnf
@@ -0,0 +1,10 @@
+[connector_python]
+user=root
+password=mypass
+database=cpydata
+port=10000
+
+[connector_python]
+user=mysql
+password=mypass
+database=duplicate_data
diff --git a/tests/test_bugs.py b/tests/test_bugs.py
@@ -2722,3 +2722,22 @@ def test_row_to_python(self):
         self.cur.execute("INSERT INTO {0} (c1) VALUES (NULL)".format(self.tbl))
         self.cur.execute("SELECT * FROM {0}".format(self.tbl))
         self.assertEqual((None, 2), self.cur.fetchone())
+
+
+class BugOra19170287(tests.MySQLConnectorTests):
+    """BUG#19170287: DUPLICATE OPTION_GROUPS RAISING ERROR WITH PYTHON 3
+    """
+    def test_duplicate_groups(self):
+        option_file_dir = os.path.join('tests', 'data', 'option_files')
+        opt_file = os.path.join(option_file_dir, 'dup_groups.cnf')
+        config = tests.get_mysql_config()
+
+        cnx = mysql.connector.connect(**config)
+        exp = {
+            u'password': u'mypass',
+            u'user': u'mysql',
+            u'database': u'duplicate_data',
+            u'port': 10000
+        }
+        self.assertEqual(exp, cnx._read_option_files(
+            {'option_files': opt_file}))
