Avoid -Wconversion warnings when using checksum_impl.h

michaelpq · michaelpq · commit 0065174324a9 · 2020-03-05T14:12:37.000+09:00
This does not matter much when compiling Postgres proper as many warnings exist when enabling this compilation flag, but it can be annoying for external modules willing to use both. Author: David Steele Discussion: https://postgr.es/m/91d86c8a-11fc-7b88-43eb-5ca3f6fb8bd3@pgmasters.net
diff --git a/src/include/storage/checksum_impl.h b/src/include/storage/checksum_impl.h
@@ -211,5 +211,5 @@ pg_checksum_page(char *page, BlockNumber blkno)
 	 * Reduce to a uint16 (to fit in the pd_checksum field) with an offset of
 	 * one. That avoids checksums of zero, which seems like a good idea.
 	 */
-	return (checksum % 65535) + 1;
+	return (uint16) ((checksum % 65536) + 1);
 }

Original file line number	Diff line number	Diff line change
`@@ -211,5 +211,5 @@ pg_checksum_page(char *page, BlockNumber blkno)`
`211`	`211`	`* Reduce to a uint16 (to fit in the pd_checksum field) with an offset of`
`212`	`212`	`* one. That avoids checksums of zero, which seems like a good idea.`
`213`	`213`	`*/`
`214`		`- return (checksum % 65535) + 1;`
	`214`	`+ return (uint16) ((checksum % 65536) + 1);`
`215`	`215`	`}`