Suppress uninitialized-variable warning.

tglsfdc · tglsfdc · commit 01add89454d5 · 2021-04-08T15:14:26.000-04:00
Several buildfarm critters that don't usually produce such warnings are complaining about e717a9a. I think it's actually safe, but move initialization to silence the warning.
diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c
@@ -916,6 +916,7 @@ fmgr_sql_validator(PG_FUNCTION_ARGS)
 			 * least catch silly syntactic errors.
 			 */
 			raw_parsetree_list = pg_parse_query(prosrc);
+			querytree_list = NIL;
 
 			if (!haspolyarg)
 			{
@@ -928,7 +929,6 @@ fmgr_sql_validator(PG_FUNCTION_ARGS)
 				/* But first, set up parameter information */
 				pinfo = prepare_sql_fn_parse_info(tuple, NULL, InvalidOid);
 
-				querytree_list = NIL;
 				foreach(lc, raw_parsetree_list)
 				{
 					RawStmt    *parsetree = lfirst_node(RawStmt, lc);

Original file line number	Diff line number	Diff line change
`@@ -916,6 +916,7 @@ fmgr_sql_validator(PG_FUNCTION_ARGS)`
`916`	`916`	`* least catch silly syntactic errors.`
`917`	`917`	`*/`
`918`	`918`	`raw_parsetree_list = pg_parse_query(prosrc);`
	`919`	`+ querytree_list = NIL;`
`919`	`920`
`920`	`921`	`if (!haspolyarg)`
`921`	`922`	`{`
`@@ -928,7 +929,6 @@ fmgr_sql_validator(PG_FUNCTION_ARGS)`
`928`	`929`	`/* But first, set up parameter information */`
`929`	`930`	`pinfo = prepare_sql_fn_parse_info(tuple, NULL, InvalidOid);`
`930`	`931`
`931`		`- querytree_list = NIL;`
`932`	`932`	`foreach(lc, raw_parsetree_list)`
`933`	`933`	`{`
`934`	`934`	`RawStmt *parsetree = lfirst_node(RawStmt, lc);`