Skip to content

Commit 049d9b8

Browse files
committed
Improve comment for struct BufferDesc.
Add a note that per-buffer I/O condition variables currently live outside the BufferDesc struct. Follow-up for commit d872510. Reported-by: Julien Rouhaud <rjuju123@gmail.com> Discussion: https://postgr.es/m/20210311031118.hucytmrgwlktjxgq%40nol
1 parent 2950ff3 commit 049d9b8

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/include/storage/buf_internals.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,10 @@ typedef struct buftag
174174
* Be careful to avoid increasing the size of the struct when adding or
175175
* reordering members. Keeping it below 64 bytes (the most common CPU
176176
* cache line size) is fairly important for performance.
177+
*
178+
* Per-buffer I/O condition variables are currently kept outside this struct in
179+
* a separate array. They could be moved in here and still fit within that
180+
* limit on common systems, but for now that is not done.
177181
*/
178182
typedef struct BufferDesc
179183
{

0 commit comments

Comments
 (0)