Remove incorrect entries in pg_walsummary's getopt_long call.

tglsfdc · tglsfdc · commit 04c64e3fb35a · 2024-09-30T12:06:54.000-04:00
For some reason this listed "-f" and "-w" as valid switches, though the code doesn't implement any such thing nor do the docs mention them. The effect of this was that if you tried to use one of these switches, you'd get an unhelpful error message. Yusuke Sugie Discussion: https://postgr.es/m/68e72a2a70f4d84c1c7847b13bcdaef8@oss.nttdata.com
diff --git a/src/bin/pg_walsummary/pg_walsummary.c b/src/bin/pg_walsummary/pg_walsummary.c
@@ -71,7 +71,7 @@ main(int argc, char *argv[])
 	handle_help_version_opts(argc, argv, progname, help);
 
 	/* process command-line options */
-	while ((c = getopt_long(argc, argv, "f:iqw:",
+	while ((c = getopt_long(argc, argv, "iq",
 							long_options, &optindex)) != -1)
 	{
 		switch (c)

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ main(int argc, char *argv[])`
`71`	`71`	`handle_help_version_opts(argc, argv, progname, help);`
`72`	`72`
`73`	`73`	`/* process command-line options */`
`74`		`- while ((c = getopt_long(argc, argv, "f:iqw:",`
	`74`	`+ while ((c = getopt_long(argc, argv, "iq",`
`75`	`75`	`long_options, &optindex)) != -1)`
`76`	`76`	`{`
`77`	`77`	`switch (c)`