Add missing newlines to PQescapeInternal() messages pre-v16.

tglsfdc · tglsfdc · commit 06a2c598e10b · 2025-05-01T17:36:47.000-04:00
While back-patching 9f45e6a, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut <peter@eisentraut.org> Discussion: https://postgr.es/m/a9c837ad-d507-4607-94e4-c5743a8f49e0@eisentraut.org Backpatch-through: 13-15
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
@@ -3410,10 +3410,10 @@ PQescapeStringInternal(PGconn *conn,
 			{
 				if (remaining < charlen)
 					printfPQExpBuffer(&conn->errorMessage,
-									  libpq_gettext("incomplete multibyte character"));
+									  libpq_gettext("incomplete multibyte character\n"));
 				else
 					printfPQExpBuffer(&conn->errorMessage,
-									  libpq_gettext("invalid multibyte character"));
+									  libpq_gettext("invalid multibyte character\n"));
 				/* Issue a complaint only once per string */
 				already_complained = true;
 			}

Original file line number	Diff line number	Diff line change
`@@ -3410,10 +3410,10 @@ PQescapeStringInternal(PGconn *conn,`
`3410`	`3410`	`{`
`3411`	`3411`	`if (remaining < charlen)`
`3412`	`3412`	`printfPQExpBuffer(&conn->errorMessage,`
`3413`		`- libpq_gettext("incomplete multibyte character"));`
	`3413`	`+ libpq_gettext("incomplete multibyte character\n"));`
`3414`	`3414`	`else`
`3415`	`3415`	`printfPQExpBuffer(&conn->errorMessage,`
`3416`		`- libpq_gettext("invalid multibyte character"));`
	`3416`	`+ libpq_gettext("invalid multibyte character\n"));`
`3417`	`3417`	`/* Issue a complaint only once per string */`
`3418`	`3418`	`already_complained = true;`
`3419`	`3419`	`}`