Remove bogus tracepoint

petere · petere · commit 09418bed67a7 · 2021-01-22T11:58:21.000+01:00
Calls to LWLockWaitForVar() fired the TRACE_POSTGRESQL_LWLOCK_ACQUIRE tracepoint, but LWLockWaitForVar() never actually acquires the LWLock. (Probably a copy/paste bug in 68a2e52.) Remove it. Author: Craig Ringer <craig.ringer@enterprisedb.com> Discussion: https://www.postgresql.org/message-id/flat/CAGRY4nxJo+-HCC2i5H93ttSZ4gZO-FSddCwvkb-qAfQ1zdXd1w@mail.gmail.com
diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.c
@@ -1725,8 +1725,6 @@ LWLockWaitForVar(LWLock *lock, uint64 *valptr, uint64 oldval, uint64 *newval)
 		/* Now loop back and check the status of the lock again. */
 	}
 
-	TRACE_POSTGRESQL_LWLOCK_ACQUIRE(T_NAME(lock), LW_EXCLUSIVE);
-
 	/*
 	 * Fix the process wait semaphore's count for any absorbed wakeups.
 	 */

Original file line number	Diff line number	Diff line change
`@@ -1725,8 +1725,6 @@ LWLockWaitForVar(LWLock lock, uint64 valptr, uint64 oldval, uint64 *newval)`
`1725`	`1725`	`/* Now loop back and check the status of the lock again. */`
`1726`	`1726`	`}`
`1727`	`1727`
`1728`		`- TRACE_POSTGRESQL_LWLOCK_ACQUIRE(T_NAME(lock), LW_EXCLUSIVE);`
`1729`		`-`
`1730`	`1728`	`/*`
`1731`	`1729`	`* Fix the process wait semaphore's count for any absorbed wakeups.`
`1732`	`1730`	`*/`