Skip to content

Commit 0a8e9c4

Browse files
author
Thomas G. Lockhart
committed
Define JoinExpr structure for outer join syntax.
Clean up comments in execnodes.h.
1 parent 70600bd commit 0a8e9c4

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

src/include/nodes/execnodes.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* Copyright (c) 1994, Regents of the University of California
88
*
9-
* $Id: execnodes.h,v 1.24 1999/02/13 23:21:37 momjian Exp $
9+
* $Id: execnodes.h,v 1.25 1999/02/23 07:55:23 thomas Exp $
1010
*
1111
*-------------------------------------------------------------------------
1212
*/
@@ -607,7 +607,7 @@ typedef struct GroupState
607607
* SortState information
608608
*
609609
*| sort nodes are really just a kind of a scan since
610-
*| we implement sorts by retrieveing the entire subplan
610+
*| we implement sorts by retrieving the entire subplan
611611
*| into a temp relation, sorting the temp relation into
612612
*| another sorted relation, and then preforming a simple
613613
*| unqualified sequential scan on the sorted relation..

src/include/nodes/nodes.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* Copyright (c) 1994, Regents of the University of California
88
*
9-
* $Id: nodes.h,v 1.43 1999/02/13 23:21:38 momjian Exp $
9+
* $Id: nodes.h,v 1.44 1999/02/23 07:55:24 thomas Exp $
1010
*
1111
*-------------------------------------------------------------------------
1212
*/
@@ -215,7 +215,7 @@ typedef enum NodeTag
215215
T_SortClause,
216216
T_GroupClause,
217217
T_SubSelect,
218-
T_JoinUsing,
218+
T_JoinExpr,
219219
T_CaseExpr,
220220
T_CaseWhen,
221221
T_RowMark

src/include/nodes/parsenodes.h

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* Copyright (c) 1994, Regents of the University of California
88
*
9-
* $Id: parsenodes.h,v 1.70 1999/02/13 23:21:39 momjian Exp $
9+
* $Id: parsenodes.h,v 1.71 1999/02/23 07:55:24 thomas Exp $
1010
*
1111
*-------------------------------------------------------------------------
1212
*/
@@ -149,7 +149,7 @@ typedef struct CreateStmt
149149

150150
typedef enum ConstrType /* type of constaints */
151151
{
152-
CONSTR_NONE, CONSTR_NOTNULL, CONSTR_DEFAULT, CONSTR_CHECK, CONSTR_PRIMARY, CONSTR_UNIQUE
152+
CONSTR_NULL, CONSTR_NOTNULL, CONSTR_DEFAULT, CONSTR_CHECK, CONSTR_PRIMARY, CONSTR_UNIQUE
153153
} ConstrType;
154154

155155
typedef struct Constraint
@@ -671,7 +671,6 @@ typedef struct SelectStmt
671671
List *forUpdate; /* FOR UPDATE clause */
672672
} SelectStmt;
673673

674-
675674
/****************************************************************************
676675
* Supporting data structures for Parse Trees
677676
****************************************************************************/
@@ -854,17 +853,6 @@ typedef struct SortGroupBy
854853
Node *node; /* Expression */
855854
} SortGroupBy;
856855

857-
/*
858-
* JoinUsing - for JOIN USING clause
859-
*/
860-
typedef struct JoinUsing
861-
{
862-
NodeTag type;
863-
int resno; /* target number */
864-
char *range;
865-
char *name; /* name of column to sort on */
866-
} JoinUsing;
867-
868856
/*
869857
* RangeVar - range variable, used in FROM clauses
870858
*/
@@ -898,6 +886,18 @@ typedef struct DefElem
898886
Node *arg; /* a (Value *) or a (TypeName *) */
899887
} DefElem;
900888

889+
/*
890+
* JoinExpr - for JOIN expressions
891+
*/
892+
typedef struct JoinExpr
893+
{
894+
NodeTag type;
895+
int jointype;
896+
RangeVar *larg;
897+
Node *rarg;
898+
List *quals;
899+
} JoinExpr;
900+
901901

902902
/****************************************************************************
903903
* Nodes for a Query tree

0 commit comments

Comments
 (0)