Place "extern" declaration in the right part of pg_class.h.

tglsfdc · tglsfdc · commit 0e032a2240a9 · 2025-03-21T15:14:15.000-04:00
errdetail_relkind_not_supported() was declared within EXPOSE_TO_CLIENT_CODE, which is mistaken since that function isn't available client-side. While relatively harmless, this isn't good precedent. Discussion: https://postgr.es/m/1134562.1742507765@sss.pgh.pa.us
diff --git a/src/include/catalog/pg_class.h b/src/include/catalog/pg_class.h
@@ -231,8 +231,8 @@ MAKE_SYSCACHE(RELNAMENSP, pg_class_relname_nsp_index, 128);
 	 (relkind) == RELKIND_TOASTVALUE || \
 	 (relkind) == RELKIND_MATVIEW)
 
-extern int	errdetail_relkind_not_supported(char relkind);
-
 #endif							/* EXPOSE_TO_CLIENT_CODE */
 
+extern int	errdetail_relkind_not_supported(char relkind);
+
 #endif							/* PG_CLASS_H */
