Fix a pg_dump scenario for platforms where SEEK_CUR != 1.

nmisch · nmisch · commit 0e164eb9f436 · 2025-06-03T11:18:52.000-07:00
POSIX allows such platforms. Given the lack of complaints, we may not currently test on such a platform. This is new in v18 (commit 7d5c83b), so no back-patch.
diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
@@ -2655,7 +2655,7 @@ WriteToc(ArchiveHandle *AH)
 				pg_fatal("unexpected TOC entry in WriteToc(): %d %s %s",
 						 te->dumpId, te->desc, te->tag);
 
-			if (fseeko(AH->FH, te->defnLen, SEEK_CUR != 0))
+			if (fseeko(AH->FH, te->defnLen, SEEK_CUR) != 0)
 				pg_fatal("error during file seek: %m");
 		}
 		else if (te->defnDumper)

Original file line number	Diff line number	Diff line change
`@@ -2655,7 +2655,7 @@ WriteToc(ArchiveHandle *AH)`
`2655`	`2655`	`pg_fatal("unexpected TOC entry in WriteToc(): %d %s %s",`
`2656`	`2656`	`te->dumpId, te->desc, te->tag);`
`2657`	`2657`
`2658`		`- if (fseeko(AH->FH, te->defnLen, SEEK_CUR != 0))`
	`2658`	`+ if (fseeko(AH->FH, te->defnLen, SEEK_CUR) != 0)`
`2659`	`2659`	`pg_fatal("error during file seek: %m");`
`2660`	`2660`	`}`
`2661`	`2661`	`else if (te->defnDumper)`