On win32, don't use SO_REUSEADDR for TCP sockets.

mhagander · mhagander · commit 0e92f9813e4e · 2007-06-04T11:59:20.000Z
Per failure on buildfarm member baiji and subsequent discussion.
diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
@@ -30,7 +30,7 @@
  * Portions Copyright (c) 1996-2007, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$PostgreSQL: pgsql/src/backend/libpq/pqcomm.c,v 1.191 2007/03/03 19:32:54 neilc Exp $
+ *	$PostgreSQL: pgsql/src/backend/libpq/pqcomm.c,v 1.192 2007/06/04 11:59:20 mha Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -337,6 +337,16 @@ StreamServerPort(int family, char *hostName, unsigned short portNumber,
 			continue;
 		}
 
+#ifndef WIN32
+		/*
+		 * Without the SO_REUSEADDR flag, a new postmaster can't be started right away after
+		 * a stop or crash, giving "address already in use" error on TCP ports.
+		 *
+		 * On win32, however, this behavior only happens if the SO_EXLUSIVEADDRUSE is set.
+		 * With SO_REUSEADDR, win32 allows multiple servers to listen on the same address,
+		 * resulting in unpredictable behavior. With no flags at all, win32 behaves as
+		 * Unix with SO_REUSEADDR.
+		 */
 		if (!IS_AF_UNIX(addr->ai_family))
 		{
 			if ((setsockopt(fd, SOL_SOCKET, SO_REUSEADDR,
@@ -349,6 +359,7 @@ StreamServerPort(int family, char *hostName, unsigned short portNumber,
 				continue;
 			}
 		}
+#endif
 
 #ifdef IPV6_V6ONLY
 		if (addr->ai_family == AF_INET6)

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`* Portions Copyright (c) 1996-2007, PostgreSQL Global Development Group`
`31`	`31`	`* Portions Copyright (c) 1994, Regents of the University of California`
`32`	`32`	`*`
`33`		`- * $PostgreSQL: pgsql/src/backend/libpq/pqcomm.c,v 1.191 2007/03/03 19:32:54 neilc Exp $`
	`33`	`+ * $PostgreSQL: pgsql/src/backend/libpq/pqcomm.c,v 1.192 2007/06/04 11:59:20 mha Exp $`
`34`	`34`	`*`
`35`	`35`	`*-------------------------------------------------------------------------`
`36`	`36`	`*/`
`@@ -337,6 +337,16 @@ StreamServerPort(int family, char *hostName, unsigned short portNumber,`
`337`	`337`	`continue;`
`338`	`338`	`}`
`339`	`339`
	`340`	`+#ifndef WIN32`
	`341`	`+ /*`
	`342`	`+ * Without the SO_REUSEADDR flag, a new postmaster can't be started right away after`
	`343`	`+ * a stop or crash, giving "address already in use" error on TCP ports.`
	`344`	`+ *`
	`345`	`+ * On win32, however, this behavior only happens if the SO_EXLUSIVEADDRUSE is set.`
	`346`	`+ * With SO_REUSEADDR, win32 allows multiple servers to listen on the same address,`
	`347`	`+ * resulting in unpredictable behavior. With no flags at all, win32 behaves as`
	`348`	`+ * Unix with SO_REUSEADDR.`
	`349`	`+ */`
`340`	`350`	`if (!IS_AF_UNIX(addr->ai_family))`
`341`	`351`	`{`
`342`	`352`	`if ((setsockopt(fd, SOL_SOCKET, SO_REUSEADDR,`
`@@ -349,6 +359,7 @@ StreamServerPort(int family, char *hostName, unsigned short portNumber,`
`349`	`359`	`continue;`
`350`	`360`	`}`
`351`	`361`	`}`
	`362`	`+#endif`
`352`	`363`
`353`	`364`	`#ifdef IPV6_V6ONLY`
`354`	`365`	`if (addr->ai_family == AF_INET6)`