Log a message when resorting to SIGKILL during shutdown/crash recovery.

tglsfdc · tglsfdc · commit 10095ca634fb · 2020-09-11T12:24:46.000-04:00
Currently, no useful trace is left in the logs when the postmaster is forced to use SIGKILL to shut down children that failed to respond to SIGQUIT. Some questions were raised about how often that scenario happens in the buildfarm, so let's add a LOG-level message showing that it happened. Discussion: https://postgr.es/m/1850884.1599601164@sss.pgh.pa.us
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -1850,6 +1850,8 @@ ServerLoop(void)
 			(now - AbortStartTime) >= SIGKILL_CHILDREN_AFTER_SECS)
 		{
 			/* We were gentle with them before. Not anymore */
+			ereport(LOG,
+					(errmsg("issuing SIGKILL to recalcitrant children")));
 			TerminateChildren(SIGKILL);
 			/* reset flag so we don't SIGKILL again */
 			AbortStartTime = 0;

Original file line number	Diff line number	Diff line change
`@@ -1850,6 +1850,8 @@ ServerLoop(void)`
`1850`	`1850`	`(now - AbortStartTime) >= SIGKILL_CHILDREN_AFTER_SECS)`
`1851`	`1851`	`{`
`1852`	`1852`	`/* We were gentle with them before. Not anymore */`
	`1853`	`+ ereport(LOG,`
	`1854`	`+ (errmsg("issuing SIGKILL to recalcitrant children")));`
`1853`	`1855`	`TerminateChildren(SIGKILL);`
`1854`	`1856`	`/* reset flag so we don't SIGKILL again */`
`1855`	`1857`	`AbortStartTime = 0;`