Skip to content

Commit 17d8bba

Browse files
committed
Fix copy-paste error related to the autovacuum launcher in pgstat_io.c
Autovacuum launchers perform no WAL IO reads, but pgstat_tracks_io_op() was tracking them as an allowed combination for the "init" and "normal" contexts. This caused the "read", "read_bytes" and "read_time" attributes of pg_stat_io to show zeros for the autovacuum launcher rather than NULL. NULL means that a combination of IO object, IO context and IO operation has no meaning for a backend type. Zero is the same as telling that a combination is relevant, and that WAL reads are possible in an autovacuum launcher, but it is not relevant. Copy-pasto introduced in a051e71. Author: Ranier Vilela <ranier.vf@gmail.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAEudQAopEMAPiUqE7BvDV+x2fUPmKmb9RrsaoDR+hhQzLKg4PQ@mail.gmail.com
1 parent f4290f2 commit 17d8bba

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/backend/utils/activity/pgstat_io.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ pgstat_tracks_io_op(BackendType bktype, IOObject io_object,
512512
*/
513513
if (io_object == IOOBJECT_WAL && io_op == IOOP_READ &&
514514
(bktype == B_WAL_RECEIVER || bktype == B_BG_WRITER ||
515-
bktype == B_AUTOVAC_WORKER || bktype == B_AUTOVAC_WORKER ||
515+
bktype == B_AUTOVAC_LAUNCHER || bktype == B_AUTOVAC_WORKER ||
516516
bktype == B_WAL_WRITER))
517517
return false;
518518

0 commit comments

Comments
 (0)