Remove ineffective heapam CHECK_FOR_INTERRUPTS().

petergeoghegan · petergeoghegan · commit 180cf876d457 · 2020-11-09T09:00:12.000-08:00
Remove a CHECK_FOR_INTERRUPTS() call that could never actually handle an
interrupt.  We always have a heap page buffer lock at this point.
Having a useless CHECK_FOR_INTERRUPTS() call is harmless but misleading.

It is probably possible to work around the immediate problem by moving
the CHECK_FOR_INTERRUPTS() to before the heap page buffer lock is
acquired.  That isn't enough to make the function responsive to
interrupts, though.  The index AM caller will still hold an exclusive
buffer lock of its own.
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -7086,7 +7086,6 @@ heap_compute_xid_horizon_for_tuples(Relation rel,
 		{
 			hoffnum = ItemIdGetRedirect(hitemid);
 			hitemid = PageGetItemId(hpage, hoffnum);
-			CHECK_FOR_INTERRUPTS();
 		}
 
 		/*

Original file line number	Diff line number	Diff line change
`@@ -7086,7 +7086,6 @@ heap_compute_xid_horizon_for_tuples(Relation rel,`
`7086`	`7086`	`{`
`7087`	`7087`	`hoffnum = ItemIdGetRedirect(hitemid);`
`7088`	`7088`	`hitemid = PageGetItemId(hpage, hoffnum);`
`7089`		`- CHECK_FOR_INTERRUPTS();`
`7090`	`7089`	`}`
`7091`	`7090`
`7092`	`7091`	`/*`