Skip to content

Commit 1b0d9aa

Browse files
david-rowleydavid-rowley
committed
Improve the generation memory allocator
Here we make a series of improvements to the generation memory allocator, namely: 1. Allow generation contexts to have a minimum, initial and maximum block sizes. The standard allocator allows this already but when the generation context was added, it only allowed fixed-sized blocks. The problem with fixed-sized blocks is that it's difficult to choose how large to make the blocks. If the chosen size is too small then we'd end up with a large number of blocks and a large number of malloc calls. If the block size is made too large, then memory is wasted. 2. Add support for "keeper" blocks. This is a special block that is allocated along with the context itself but is never freed. Instead, when the last chunk in the keeper block is freed, we simply mark the block as empty to allow new allocations to make use of it. 3. Add facility to "recycle" newly empty blocks instead of freeing them and having to later malloc an entire new block again. We do this by recording a single GenerationBlock which has become empty of any chunks. When we run out of space in the current block, we check to see if there is a "freeblock" and use that if it contains enough space for the allocation. Author: David Rowley, Tomas Vondra Reviewed-by: Andy Fan Discussion: https://postgr.es/m/d987fd54-01f8-0f73-af6c-519f799a0ab8@enterprisedb.com
1 parent cc58eec commit 1b0d9aa

File tree

4 files changed

+325
-77
lines changed

4 files changed

+325
-77
lines changed

‎src/backend/access/gist/gistvacuum.c

+6
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,15 @@ gistvacuumscan(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
158158
* pages in page_set_context. Internally, the integer set will remember
159159
* this context so that the subsequent allocations for these integer sets
160160
* will be done from the same context.
161+
*
162+
* XXX the allocation sizes used below pre-date generation context's block
163+
* growing code. These values should likely be benchmarked and set to
164+
* more suitable values.
161165
*/
162166
vstate.page_set_context = GenerationContextCreate(CurrentMemoryContext,
163167
"GiST VACUUM page set context",
168+
16 * 1024,
169+
16 * 1024,
164170
16 * 1024);
165171
oldctx = MemoryContextSwitchTo(vstate.page_set_context);
166172
vstate.internal_page_set = intset_create();

‎src/backend/replication/logical/reorderbuffer.c

+7
Original file line numberDiff line numberDiff line change
@@ -370,8 +370,15 @@ ReorderBufferAllocate(void)
370370
SLAB_DEFAULT_BLOCK_SIZE,
371371
sizeof(ReorderBufferTXN));
372372

373+
/*
374+
* XXX the allocation sizes used below pre-date generation context's block
375+
* growing code. These values should likely be benchmarked and set to
376+
* more suitable values.
377+
*/
373378
buffer->tup_context = GenerationContextCreate(new_ctx,
374379
"Tuples",
380+
SLAB_LARGE_BLOCK_SIZE,
381+
SLAB_LARGE_BLOCK_SIZE,
375382
SLAB_LARGE_BLOCK_SIZE);
376383

377384
hash_ctl.keysize = sizeof(TransactionId);

0 commit comments

Comments
 (0)