Remove useless Assert.

tglsfdc · tglsfdc · commit 1c164ef3d28d · 2020-08-09T11:32:31.000-04:00
Testing that an unsigned variable is &gt;= 0 is pretty pointless,
as noted by Coverity and numerous buildfarm members.

In passing, add comment about new uses of "volatile" --- Coverity
doesn't much like that either, but it seems probably necessary.
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
@@ -1907,6 +1907,9 @@ ReorderBufferResetTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
  * merge) and replay the changes in lsn order.
  *
  * If streaming is true then data will be sent using stream API.
+ *
+ * Note: "volatile" markers on some parameters are to avoid trouble with
+ * PG_TRY inside the function.
  */
 static void
 ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
@@ -2762,7 +2765,6 @@ ReorderBufferChangeMemoryUpdate(ReorderBuffer *rb,
 	}
 
 	Assert(txn->size <= rb->size);
-	Assert((txn->size >= 0) && (rb->size >= 0));
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -1907,6 +1907,9 @@ ReorderBufferResetTXN(ReorderBuffer rb, ReorderBufferTXN txn,`
`1907`	`1907`	`* merge) and replay the changes in lsn order.`
`1908`	`1908`	`*`
`1909`	`1909`	`* If streaming is true then data will be sent using stream API.`
	`1910`	`+ *`
	`1911`	`+ * Note: "volatile" markers on some parameters are to avoid trouble with`
	`1912`	`+ * PG_TRY inside the function.`
`1910`	`1913`	`*/`
`1911`	`1914`	`static void`
`1912`	`1915`	`ReorderBufferProcessTXN(ReorderBuffer rb, ReorderBufferTXN txn,`
`@@ -2762,7 +2765,6 @@ ReorderBufferChangeMemoryUpdate(ReorderBuffer *rb,`
`2762`	`2765`	`}`
`2763`	`2766`
`2764`	`2767`	`Assert(txn->size <= rb->size);`
`2765`		`- Assert((txn->size >= 0) && (rb->size >= 0));`
`2766`	`2768`	`}`
`2767`	`2769`
`2768`	`2770`	`/*`