Fix newly introduced 010_keep_recycled_wals.pl

alvherre · alvherre · commit 1c5fe56bc259 · 2024-11-21T17:06:48.000+01:00
It failed to set the archive_command as it desired because of a syntax problem. Oversight in commit 90bcc7c. This bug doesn't cause the test to fail, because the test only checks pg_rewind's output messages, not the actual outcome (and the outcome in both cases is that the file is kept, not deleted). But in either case the message about the file being kept is there, so it's hard to get excited about doing much more. Reported-by: Antonin Houska <ah@cybertec.at> Author: Alexander Kukushkin <cyberdemn@gmail.com> Discussion: https://postgr.es/m/7822.1732167825@antos
diff --git a/src/bin/pg_rewind/t/010_keep_recycled_wals.pl b/src/bin/pg_rewind/t/010_keep_recycled_wals.pl
@@ -23,9 +23,9 @@
 
 RewindTest::primary_psql("CHECKPOINT");    # last common checkpoint
 
-# We use "perl -e 'exit(1)'" as an alternative to "false", because the latter
+# We use `perl -e "exit(1)"` as an alternative to "false", because the latter
 # might not be available on Windows.
-my $false = "$^X -e 'exit(1)'";
+my $false = "$^X -e \"exit(1)\"";
 $node_primary->append_conf(
 	'postgresql.conf', qq(
 archive_command = '$false'
