oauth: Simplify copy of PGoauthBearerRequest

macdice · macdice · commit 1cf4c56480f8 · 2025-03-19T16:59:25.000+13:00
Follow-up to 03366b6. Since there are no more const members in the PGoauthBearerRequest struct, the previous memcpy() can be replaced with simple assignment. Author: Jacob Champion <jacob.champion@enterprisedb.com> Discussion: https://postgr.es/m/p4bd7mn6dxr2zdak74abocyltpfdxif4pxqzixqpxpetjwt34h%40qc6jgfmoddvq
diff --git a/src/interfaces/libpq/fe-auth-oauth.c b/src/interfaces/libpq/fe-auth-oauth.c
@@ -781,7 +781,7 @@ setup_token_request(PGconn *conn, fe_oauth_state *state)
 			goto fail;
 		}
 
-		memcpy(request_copy, &request, sizeof(request));
+		*request_copy = request;
 
 		conn->async_auth = run_user_oauth_flow;
 		conn->cleanup_async_auth = cleanup_user_oauth_flow;

Original file line number	Diff line number	Diff line change
`@@ -781,7 +781,7 @@ setup_token_request(PGconn conn, fe_oauth_state state)`
`781`	`781`	`goto fail;`
`782`	`782`	`}`
`783`	`783`
`784`		`- memcpy(request_copy, &request, sizeof(request));`
	`784`	`+ *request_copy = request;`
`785`	`785`
`786`	`786`	`conn->async_auth = run_user_oauth_flow;`
`787`	`787`	`conn->cleanup_async_auth = cleanup_user_oauth_flow;`