Skip to content

Commit 2710ccd

Browse files
committed
Reduce wal_retrieve_retry_interval in applicable TAP tests.
By default, wal_retrieve_retry_interval is five seconds, which is far more than is needed in any of our TAP tests, leaving the test cases just twiddling their thumbs for significant stretches. Moreover, because it's so large, we get basically no testing of the retry-before- master-is-ready code path. Hence, make PostgresNode::init set up wal_retrieve_retry_interval = '500ms' as part of its customization of test clusters' postgresql.conf. This shaves quite a few seconds off the runtime of the recovery TAP tests. Back-patch into 9.6. We have wal_retrieve_retry_interval in 9.5, but the test infrastructure isn't there. Discussion: https://postgr.es/m/31624.1498500416@sss.pgh.pa.us
1 parent e5d494d commit 2710ccd

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/test/perl/PostgresNode.pm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,7 @@ sub init
414414
print $conf "restart_after_crash = off\n";
415415
print $conf "log_line_prefix = '%m [%p] %q%a '\n";
416416
print $conf "log_statement = all\n";
417+
print $conf "wal_retrieve_retry_interval = '500ms'\n";
417418
print $conf "port = $port\n";
418419

419420
if ($params{allows_streaming})

0 commit comments

Comments
 (0)