Fix MSVC pg_upgrade test.

nathan-bossart · nathan-bossart · commit 27d3dee68074 · 2025-08-11T12:37:00.000-05:00
In the back-branch versions of commit 71ea0d6, I missed updating this test to use --restrict-key so that the generated dump output is comparable. Per buildfarm member hamerkop. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Security: CVE-2025-8714 Backpatch-through: 13-14
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -644,7 +644,7 @@ sub upgradecheck
 	# now we can chdir into the source dir
 	chdir "$topdir/src/bin/pg_upgrade";
 	print "\nDumping old cluster\n\n";
-	@args = ('pg_dumpall', '-f', "$tmp_root/dump1.sql");
+	@args = ('pg_dumpall', '-f', "$tmp_root/dump1.sql", '--restrict-key', 'test');
 	system(@args) == 0 or exit 1;
 	print "\nStopping old cluster\n\n";
 	system("pg_ctl stop") == 0 or exit 1;
@@ -660,7 +660,7 @@ sub upgradecheck
 	print "\nSetting up stats on new cluster\n\n";
 	system(".\\analyze_new_cluster.bat") == 0 or exit 1;
 	print "\nDumping new cluster\n\n";
-	@args = ('pg_dumpall', '-f', "$tmp_root/dump2.sql");
+	@args = ('pg_dumpall', '-f', "$tmp_root/dump2.sql", '--restrict-key', 'test');
 	system(@args) == 0 or exit 1;
 	print "\nStopping new cluster\n\n";
 	system("pg_ctl stop") == 0 or exit 1;
