Skip to content

Commit 289121a

Browse files
committed
Remove event trigger from object_address test
It is causing trouble when run in parallel mode, because dropping the function other sessions are running concurrently causes them to fail due to inability to find the function. Per buildfarm, as noted by Tom Lane.
1 parent 0e5680f commit 289121a

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/test/regress/expected/object_address.out

+2-5
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ CREATE DOMAIN addr_nsp.gendomain AS int4 CONSTRAINT domconstr CHECK (value > 0);
2828
CREATE FUNCTION addr_nsp.trig() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN END; $$;
2929
CREATE TRIGGER t BEFORE INSERT ON addr_nsp.gentable FOR EACH ROW EXECUTE PROCEDURE addr_nsp.trig();
3030
CREATE POLICY genpol ON addr_nsp.gentable;
31-
CREATE FUNCTION addr_nsp.etrig() RETURNS EVENT_TRIGGER LANGUAGE plpgsql AS $$ BEGIN END; $$;
32-
CREATE EVENT TRIGGER evttrig ON ddl_command_end EXECUTE PROCEDURE addr_nsp.etrig();
3331
-- test some error cases
3432
SELECT pg_get_object_address('stone', '{}', '{}');
3533
ERROR: unrecognized object type "stone"
@@ -338,7 +336,7 @@ WITH objects (type, name, args) AS (VALUES
338336
('server', '{addr_fserv}', '{}'),
339337
-- user mapping
340338
-- extension
341-
('event trigger', '{evttrig}', '{}'),
339+
-- event trigger
342340
('policy', '{addr_nsp, gentable, genpol}', '{}')
343341
)
344342
SELECT (pg_identify_object(classid, objid, subobjid)).*
@@ -377,12 +375,11 @@ ORDER BY classid, objid;
377375
operator family | pg_catalog | integer_ops | pg_catalog.integer_ops for btree
378376
policy | | | genpol on addr_nsp.gentable
379377
collation | pg_catalog | "default" | pg_catalog."default"
380-
event trigger | | evttrig | evttrig
381378
text search dictionary | addr_nsp | addr_ts_dict | addr_nsp.addr_ts_dict
382379
text search parser | addr_nsp | addr_ts_prs | addr_nsp.addr_ts_prs
383380
text search configuration | addr_nsp | addr_ts_conf | addr_nsp.addr_ts_conf
384381
text search template | addr_nsp | addr_ts_temp | addr_nsp.addr_ts_temp
385-
(36 rows)
382+
(35 rows)
386383

387384
---
388385
--- Cleanup resources

src/test/regress/sql/object_address.sql

+1-4
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ CREATE FUNCTION addr_nsp.trig() RETURNS TRIGGER LANGUAGE plpgsql AS $$ BEGIN END
3333
CREATE TRIGGER t BEFORE INSERT ON addr_nsp.gentable FOR EACH ROW EXECUTE PROCEDURE addr_nsp.trig();
3434
CREATE POLICY genpol ON addr_nsp.gentable;
3535

36-
CREATE FUNCTION addr_nsp.etrig() RETURNS EVENT_TRIGGER LANGUAGE plpgsql AS $$ BEGIN END; $$;
37-
CREATE EVENT TRIGGER evttrig ON ddl_command_end EXECUTE PROCEDURE addr_nsp.etrig();
38-
3936
-- test some error cases
4037
SELECT pg_get_object_address('stone', '{}', '{}');
4138
SELECT pg_get_object_address('table', '{}', '{}');
@@ -159,7 +156,7 @@ WITH objects (type, name, args) AS (VALUES
159156
('server', '{addr_fserv}', '{}'),
160157
-- user mapping
161158
-- extension
162-
('event trigger', '{evttrig}', '{}'),
159+
-- event trigger
163160
('policy', '{addr_nsp, gentable, genpol}', '{}')
164161
)
165162
SELECT (pg_identify_object(classid, objid, subobjid)).*

0 commit comments

Comments
 (0)