Add missing exit() in pg_verifybackup when failing to find pg_waldump

michaelpq · michaelpq · commit 2ad98fdf53ed · 2021-07-29T10:59:49.000+09:00
pg_verifybackup needs by default pg_waldump to check after a range of WAL segments required for a backup, except if --no-parse-wal is specified. The code checked for the presence of the binary pg_waldump in an installation and reported an error, but it forgot to properly exit(). This could lead to confusing errors reported. Reviewed-by: Robert Haas, Fabien Coelho Discussion: https://postgr.es/m/YQDMdB+B68yePFeT@paquier.xyz Backpatch-through: 13
diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c
@@ -304,6 +304,7 @@ main(int argc, char **argv)
 							 "but was not the same version as %s.\n"
 							 "Check your installation.",
 							 "pg_waldump", full_path, "pg_verifybackup");
+			exit(1);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -304,6 +304,7 @@ main(int argc, char **argv)`
`304`	`304`	`"but was not the same version as %s.\n"`
`305`	`305`	`"Check your installation.",`
`306`	`306`	`"pg_waldump", full_path, "pg_verifybackup");`
	`307`	`+ exit(1);`
`307`	`308`	`}`
`308`	`309`	`}`
`309`	`310`