initdb: Do not report default autovacuum_worker_slots.

nathan-bossart · nathan-bossart · commit 2b49492eda3f · 2025-04-29T11:41:42.000-05:00
Commit 6d01541 taught initdb to lower the default value of autovacuum_worker_slots for systems with very few semaphores. It also added a "fake" report for the chosen value, i.e., initdb prints a message about selecting the default, but the value was already selected in a previous test. Per discussion, this is not a precedent we want to set, and it seems unnecessary to report everything derived from max_connections, so let's remove the "fake" report. Reported-by: Peter Eisentraut <peter@eisentraut.org> Suggested-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/de722583-4ba4-4063-bc41-e20684978116%40eisentraut.org
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -1186,13 +1186,6 @@ test_config_settings(void)
 
 	printf("%d\n", n_connections);
 
-	/*
-	 * We chose the default for autovacuum_worker_slots during the
-	 * max_connections tests above, but we print a progress message anyway.
-	 */
-	printf(_("selecting default \"autovacuum_worker_slots\" ... %d\n"),
-		   n_av_slots);
-
 	printf(_("selecting default \"shared_buffers\" ... "));
 	fflush(stdout);
 
