Remember to drop roles created by regression tests.

tglsfdc · tglsfdc · commit 2cdc1389a25b · 2017-03-25T17:25:28.000-04:00
Commit e3920ac created "regress_subscription_user2" in subscription.sql, but forgot to drop it, causing the regression tests to fail if run twice without re-initdb'ing.
diff --git a/src/test/regress/expected/subscription.out b/src/test/regress/expected/subscription.out
@@ -119,4 +119,5 @@ DROP SUBSCRIPTION testsub NODROP SLOT;  -- fail
 ERROR:  subscription "testsub" does not exist
 RESET SESSION AUTHORIZATION;
 DROP ROLE regress_subscription_user;
+DROP ROLE regress_subscription_user2;
 DROP ROLE regress_subscription_user_dummy;
diff --git a/src/test/regress/sql/subscription.sql b/src/test/regress/sql/subscription.sql
@@ -92,4 +92,5 @@ DROP SUBSCRIPTION testsub NODROP SLOT;  -- fail
 
 RESET SESSION AUTHORIZATION;
 DROP ROLE regress_subscription_user;
+DROP ROLE regress_subscription_user2;
 DROP ROLE regress_subscription_user_dummy;
